Clean up some clippy warnings #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is one "real" change here which is that the visit_byte_buf method was previously dead code because the "alloc" feature was not defined (and the crate depends unconditionally on std). Instead of deleting the method I removed the conditional so that the method will be included.
lann
reviewed
May 10, 2024
| @@ -39,7 +39,7 @@ fn validate_input(input: Vec<EnvelopeData>) -> Result<LogState> { | |||
| let key = signing::PrivateKey::decode(e_data.key.clone()).unwrap(); | |||
| let mut record: operator::OperatorRecord = e_data.contents.try_into().unwrap(); | |||
|
|
|||
| record.prev = last.clone(); | |||
| record.prev.clone_from(last); | |||
There was a problem hiding this comment.
I was surprised that clippy would recommend a readability regression like this and it looks like I am not alone: rust-lang/rust-clippy#12778
There was a problem hiding this comment.
Want to disable the lint rather than make this change?
There was a problem hiding this comment.
eh, given its just in tests its probably fine to leave this PR as-is.
| @@ -91,6 +91,7 @@ pub struct NewCheckpoint<'a> { | |||
|
|
|||
| #[derive(Queryable)] | |||
| #[diesel(table_name = checkpoints)] | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
What was marked dead here? I'm surprised anything in a #[derive(Queryable)] would be...
There was a problem hiding this comment.
The timestamp fields. The query fills them in, but nothing reads them.
There was a problem hiding this comment.
Ah yeah I guess Queryable would be read-only wouldn't it? 👍
lann
approved these changes
May 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused imports, use
clone_fromwhere appropriate, allow unread fields on a Postgres-related structure, and fix a#[cfg(feature = ...)]referencing a non-existent feature.