Fix data corruption #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fev2r ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Ahhhg I really should have caught this when updating dependencies a couple weeks back. Maybe this is the thing that finally motivates me to write some tests and/or make a script for downloading old data from archives = ) |
|
Actually let's hold off on this hotfix as a proper fix is coming soon: petamoriken/float16#1046 (comment) |
|
Great - thanks Em! I will hold off on doing anything for now!
Mike Gravina
(508) 667-6162
***@***.***
…________________________________
From: Em Zhan ***@***.***>
Sent: Monday, September 18, 2023 9:05 AM
To: byrd-polar/fluid-earth ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [byrd-polar/fluid-earth] Pin float16 dependency to old version (PR #49)
Actually let's hold off on this hotfix as a proper fix is coming soon: petamoriken/float16#1046 (comment) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread. Message
Actually let's hold off on this hotfix as a proper fix is coming soon: petamoriken/float16#1046 (comment)<https://urldefense.com/v3/__https://github.com/petamoriken/float16/issues/1046*issuecomment-1722465697__;Iw!!KGKeukY!0b_YpjjTp1227ODdtKzjiVqQ3Na81kot600VEGIsmMeWzBKJrCkMJgm8NsRxuEKrsjyOpV169_xqm6pz8ReMXFhEqQ$>
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/byrd-polar/fluid-earth/pull/49*issuecomment-1723366886__;Iw!!KGKeukY!0b_YpjjTp1227ODdtKzjiVqQ3Na81kot600VEGIsmMeWzBKJrCkMJgm8NsRxuEKrsjyOpV169_xqm6pz8ReDW9pgxw$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AFJHJW3HPO42AU3YO32OBW3X3BBIHANCNFSM6AAAAAA42OTMR4__;!!KGKeukY!0b_YpjjTp1227ODdtKzjiVqQ3Na81kot600VEGIsmMeWzBKJrCkMJgm8NsRxuEKrsjyOpV169_xqm6pz8RfhQhR44w$>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Includes fix for a data corruption issue in float16
zqianem
force-pushed
the
fix-data-corruption
branch
from
ffe4116
to
7d07b48
Compare
|
Upstream fix was released, so instead of pinning the version this PR just updates all dependencies. The failing Netlify checks can be ignored, looks like a cache issue that fixed itself on retry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for a data corruption issue where some scattered pixel values (most noticeable in wind speed data) were wrong
See the random blue pixels above
Will investigate further and report upstream when I have the time