Upload agent images to GHCR #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
pent-9-images-to-ghcr
branch
from
8e1bd2e
to
5f7aabe
Compare
DrJosh9000
changed the title
DrJosh9000
force-pushed
the
pent-9-images-to-ghcr
branch
from
5f7aabe
to
2ebe153
Compare
moskyb
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
this looks great! very happy to ship it.
when i was working on the k8s stack, one thing that would have been useful would have been publishing per-branch docker images to ghcr, so that we can test development branches of the agent in the kubernetes stack. i don't think we should do this in this PR (unless it's really easy?), but something to keep in mind for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make agent images accessible directly from GHCR.
This relates to pinning agent versions used by the k8s stack, which currently publishes images and helm charts to GHCR. Some customers might also be interested in pulling from GHCR instead of Docker Hub.
Context
https://linear.app/buildkite/issue/PENT-9/pin-the-version-of-the-buildkite-agent-used-by-agent-stack-k8s
Changes
docker loginto GitHub using the existing credentialskopeo copythe image to ghcr.io/buildkite/agentTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)I also ran a modified release pipeline to verify that it works.