Don't run pre-exit hooks without command phase #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
pent-10-no-pre-exit-without-command-phase
branch
from
be91ebe
to
86b3a16
Compare
DrJosh9000
changed the title
moskyb
approved these changes
Apr 2, 2024
Comment on lines
-183
to
-193
| includePhase := func(phase string) bool { | ||
| if len(e.Phases) == 0 { | ||
| return true | ||
| } | ||
| for _, include := range e.Phases { | ||
| if include == phase { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
i have looked at this code and thought "why is this an inline closure? i should make it a method" and then... not for the entire time i've worked here. thank you for making it happen!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The k8s stack uses phases to split job execution between multiple containers. In particular, the checkout phase happens in a separate container to the command phase. This makes pre-exit hook execute twice, once in each container - this is usually not what is intended by plugin authors, and often breaks when the different phase have different configs or environment variables.
Changing it so pre-exit hooks only run if the command phase is enabled makes it work, and is unlikely to break anybody (who isn't deep in the agent fiddling with phases).
Context
https://linear.app/buildkite/issue/PENT-10/make-hooks-configurable
Changes
includePhasefrom inline closure to methodcommandTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)