Ensure that disabled warnings get passed to the logger in kubernetes agents #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #2674, we added a feature to the agent where some warnings would be "dismissable" through CLI flags - for example, one could disable this warning:
by passing
--disable-warnings-for "submodules-disabled".However, due to an oversight, this feature wasn't working on Kubernetes agents. This PR fixes that issue by correctly passing the config down the the customised logger that K8s pods use, and making it harder for developers to miss this kind of thing in the future.
Context
#2674
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)