De-experiment isolated plugin checkout #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
reviewed
Mar 20, 2024
Comment on lines
+57
to
+63
| ANSITimestamps: standardPromotionMsg(ANSITimestamps, "v3.48.0"), | ||
| AvoidRecursiveTrap: standardPromotionMsg(AvoidRecursiveTrap, "v3.66.0"), | ||
| FlockFileLocks: standardPromotionMsg(FlockFileLocks, "v3.48.0"), | ||
| GitMirrors: standardPromotionMsg(GitMirrors, "v3.47.0"), | ||
| InbuiltStatusPage: standardPromotionMsg(InbuiltStatusPage, "v3.48.0"), | ||
| IsolatedPluginCheckout: standardPromotionMsg(IsolatedPluginCheckout, "v3.67.0"), | ||
| JobAPI: standardPromotionMsg(JobAPI, "v3.64.0"), |
There was a problem hiding this comment.
should we sort these by version number instead of alphabetically?
There was a problem hiding this comment.
I think that's a good idea, but enforcing it will not be straight forward at the moment. Always happy to review a PR by you that does it.
There was a problem hiding this comment.
Why by version number? Not really seeing a reason
There was a problem hiding this comment.
eh, i was thinking to sort by recency? but also it really doesn't matter that much, i think
DrJosh9000
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Isolated plugin checkout was an experiment that ensures each agent worker checks out plugins into a separate directory.
The experiment was made because the previous behavior of sharing the a plugin's directory between agents works was not locking the checkouts correctly.
If two agent workers run two different version of a plugin concurrenlty, the worker that checked out last would control the version of the plugin used by both agent workers.
A solution involving shared and exclusive locks was proposed at the time, but as plugins are usually a small collection of bash scripts, the complexity of the solution was not worth the benefit.
Context
#2301
https://coda.io/d/Escalations-Feedback_dHnUHNps1YO/Escalations_sudOj#Escalations-Table_tuS42/r22&view=modal
Changes
Promote the isolated plugin checkout experiment so that the only behavior is that each work has an independent copy of every plugin.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)