Silence Job API Log Group #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Job API prints a log group whenever it starts, which is usually once per job, but can be more than on agent-stack-k8s. However, I think the Job API should be transparent to the user: it is not that relevant to them unless they are developing against it, which should the minority of the time they are using buildkite. This removes the log group appearing in the job logs unless debug is enabled.
DrJosh9000
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Job API prints a log group whenever it starts, which is usually once
per job, but can be more than on agent-stack-k8s. However, I think the
Job API should be transparent to the user: it is not that relevant to
them unless they are developing against it, which should the minority of
the time they are using buildkite. This removes the log group appearing in
the job logs unless debug is enabled.
Context
This is a screenshot showing multiple job api log groups in a k8s job. It's a bit spammy.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)