Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle warnings from go-pipeline Parse #2675

Merged
merged 2 commits into from Apr 2, 2024
Merged

Handle warnings from go-pipeline Parse #2675

merged 2 commits into from Apr 2, 2024

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Mar 7, 2024 •
edited

Description

  • Update go-pipeline to v0.5.0
  • Display new parser warnings produced by go-pipeline

Context

https://linear.app/buildkite/issue/PS-46/json-valued-env-vars-in-pipelineyml-silently-dropped

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 force-pushed the ps-46-silent-parse-failures branch 3 times, most recently from 8c3facd to a709cbd Compare March 11, 2024 23:29
@DrJosh9000 DrJosh9000 requested a review from a team March 12, 2024 00:22
@DrJosh9000 DrJosh9000 changed the title [WIP] Handle warnings Handle warnings Apr 1, 2024
@DrJosh9000 DrJosh9000 changed the title Handle warnings Handle warnings from go-pipeline Parse Apr 1, 2024
@DrJosh9000 DrJosh9000 marked this pull request as ready for review April 1, 2024 23:49
@DrJosh9000 DrJosh9000 force-pushed the ps-46-silent-parse-failures branch 2 times, most recently from 442be18 to a022495 Compare April 1, 2024 23:58
moskyb
moskyb reviewed Apr 2, 2024
View reviewed changes
clicommand/pipeline_upload.go Outdated Show resolved Hide resolved
clicommand/tool_sign.go Outdated Show resolved Hide resolved
@tessereth
Copy link
Contributor

See buildkite/go-pipeline#27

tessereth
tessereth approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@tessereth tessereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be neat to have a test for this. But maybe that's hard. So LGTM regardless.

@DrJosh9000 DrJosh9000 merged commit c9ae9bc into main Apr 2, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the ps-46-silent-parse-failures branch April 2, 2024 03:49
@DrJosh9000 DrJosh9000 mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moskyb moskyb moskyb left review comments

@tessereth tessereth tessereth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DrJosh9000 @tessereth @moskyb