Change annotation priority default from 3 to 1 #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently annotation priority defaults are set server side, this means that agent version doesn't currently control the default (even if they mention it in the help text). This means that we're not able to pin a default annotation priority to an agent version. This updates the annotation priority to be set on the agent, not the server. It also changes the default from 3 to 1 because priority of 3 has been considered to be confusing and not intuitive. This now matches agent priority. Agent version v3.65.0 will continue to use the server side default (which will be updated to 1).
matthewborden
force-pushed
the
annotation_priority_one
branch
from
70de89d
to
a5a1956
Compare
triarius
approved these changes
Mar 7, 2024
dabarrell
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently annotation priority defaults are set server side, this means that agent version doesn't currently control the default (even if they mention it in the help text). This means that we're not able to pin a default annotation priority to an agent version.
This updates the annotation priority to be set on the agent, not the server. It also changes the default from 3 to 1 because priority of 3 has been considered to be confusing and not intuitive. This now matches agent priority.
Agent version v3.65.0 will continue to use the server side default (which will be updated to 1).