Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Version.SortableString() comparable directly with RelaxedVersion.SortableString() #25

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 7, 2025

Previously comparing a sortable string from a Version and a RelaxedVersion may have an undefined outcome.
Now it's possible to compare the sortable strings directly.
This is a breaking change, if a previous Version.SortableString() has been stored on the DB, it must be regenerated.

Verified

This commit was signed with the committer’s verified signature.
dimkl Dimitris Klouvas
….SortableString()
@cmaglie cmaglie self-assigned this Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aa0ac68) to head (fe12533).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1126      1126           
=========================================
  Hits          1126      1126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmaglie cmaglie merged commit 4f9b8a3 into master Mar 7, 2025
5 checks passed
@cmaglie cmaglie deleted the relaxed-comparators branch March 7, 2025 19:11
@per1234 per1234 added the enhancement New feature or request label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants