fix: update @azure/msal-node resolves nm reactioncommerce#1584

nodemailer/nodemailer#1584
bugslifesolutions · Nov 16, 2023 · a4660b8 · a4660b8
1 parent 4cbbbf9
commit a4660b8
Show file tree

Hide file tree

Showing 6 changed files with 417 additions and 64 deletions.
diff --git a/.github/workflows/prerelease.yml b/.github/workflows/prerelease.yml
@@ -1,9 +1,8 @@
 name: PRERELEASE
 on:
-  workflow_dispatch:
+  pull_request:
     branches:
       - prerelease
-  pull_request:
     types:
       - closed
 

diff --git a/packages/bl-api-plugin-nodemailer/package.json b/packages/bl-api-plugin-nodemailer/package.json
@@ -26,7 +26,7 @@
   },
   "sideEffects": false,
   "dependencies": {
-    "@azure/msal-node": "~2.4.0",
+    "@azure/msal-node": "^2.5.1",
     "@bugslifesolutions/api-utils": "workspace:^2.0.0",
     "@bugslifesolutions/logger": "workspace:^1.1.5",
     "@bugslifesolutions/random": "workspace:^1.0.2",

diff --git a/packages/bl-api-plugin-nodemailer/src/config.js b/packages/bl-api-plugin-nodemailer/src/config.js
diff --git a/packages/bl-api-plugin-nodemailer/src/config_applianceshack.js b/packages/bl-api-plugin-nodemailer/src/config_applianceshack.js
diff --git a/packages/bl-api-plugin-nodemailer/src/util/NodemailerProxy.js b/packages/bl-api-plugin-nodemailer/src/util/NodemailerProxy.js
@@ -23,7 +23,6 @@ export default async function sendEmail(context, {
   // see https://nodemailer.com/smtp/customauth/
 
   if (nodemailerTransportOptions.auth.method !== undefined) {
-    hackForNodemailerIssue1584(nodemailerTransportOptions.auth);
     nodemailerTransportOptions.customAuth = {
       msalClientCredentialAuth
     };
@@ -39,15 +38,3 @@ export default async function sendEmail(context, {
     }
   });
 }
-
-/**
- *
- * @param {Object} auth Nodemailer auth configuration.
- * @see https://nodemailer.com/smtp/oauth2/
- * @returns {undefined}
- */
-function hackForNodemailerIssue1584(auth) {
-  // see https://github.com/nodemailer/nodemailer/issues/1584
-  auth.user = auth.user || "placeholder";
-  auth.pass = auth.pass || "placeholder";
-}