Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to google.golang.org/protobuf (v2) via protoc-gen-star v2 #783

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Migrate to google.golang.org/protobuf (v2) via protoc-gen-star v2 #783

merged 6 commits into from
Feb 8, 2023
+46 −36

Conversation

pdecks
Copy link
Contributor

@pdecks pdecks commented Jan 31, 2023 •
edited
Loading

protoc-gen-star/v2 migrated from github.com/golang/protobuf (v1) to google.golang.org/protobuf (v2). This PR removes the underlying dependency on github.com/golang/protobuf by upgrading to protoc-gen-star/v2.

see changelog: lyft/protoc-gen-star@v0.6.2...v2.0.1

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pdecks
Copy link
Contributor Author

pdecks commented Feb 2, 2023

cc @elliotmjackson for visibility since this is my first contribution 😄

elliotmjackson
elliotmjackson suggested changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@elliotmjackson elliotmjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and nudge @pdecks! you'll just want to revert your change to validate/validate.pb.go and this will be good to go.

@pdecks
Copy link
Contributor Author

pdecks commented Feb 2, 2023

Thanks for the contribution and nudge @pdecks! you'll just want to revert your change to validate/validate.pb.go and this will be good to go.

Great, thanks! I just pushed up that revert commit.

@pdecks pdecks requested a review from elliotmjackson February 6, 2023 16:46
elliotmjackson
elliotmjackson previously approved these changes Feb 6, 2023
View reviewed changes
@elliotmjackson elliotmjackson enabled auto-merge (squash) February 6, 2023 17:42
auto-merge was automatically disabled February 6, 2023 18:44

Head branch was pushed to by a user without write access

@pdecks pdecks requested a review from elliotmjackson February 6, 2023 18:47
@pdecks
Copy link
Contributor Author

pdecks commented Feb 6, 2023

Pardon the multiple pings -- the CI tests weren't running initially so I thought I needed re-approval.

@elliotmjackson
Copy link
Contributor

@pdecks feel free to run make ci locally, it should give you enough confidence that it will pass in github

@pdecks
Copy link
Contributor Author

pdecks commented Feb 7, 2023 •
edited
Loading

@pdecks feel free to run make ci locally, it should give you enough confidence that it will pass in github

Thanks, @elliotmjackson ! It took me a minute to figure out how to work with Bazel.

@elliotmjackson elliotmjackson enabled auto-merge (squash) February 8, 2023 17:12
@elliotmjackson elliotmjackson merged commit 38260ee into bufbuild:main Feb 8, 2023
@alexbozhenko alexbozhenko mentioned this pull request Jun 22, 2023
Merged
rodaine added a commit that referenced this pull request Jun 23, 2023
@alexbozhenko @rodaine
Fix name of protoc_gen_star_v2 repo (#900)
9652357 
When this project is used in a repo that uses Gazelle, the build fails
with the following error:

#535 (comment)

That error was introduced when protoc_gen_star was updated to v2 in
#783
and `dependencies.bzl` was (I believe) manually updated.

Should gazelle be used to update `dependencies.bzl`, it would choose
`com_github_lyft_protoc_gen_star_v2` as a name for the repo, as I showed
here:
alexbozhenko#1

This PR updates all references to that repo to use the correct name,
which is expected by Gazelle.
PR was created with:
```
sed -i 's/com_github_lyft_protoc_gen_star/com_github_lyft_protoc_gen_star_v2/g' $(rg -l com_github_lyft_protoc_gen_star)
```

Co-authored-by: Chris Roche <github@rodaine.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotmjackson elliotmjackson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pdecks @CLAassistant @elliotmjackson