Update rr-server-php, connectrpc/kotlin, connectrpc/swift, grpc/java plugins #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![app-token-plugins[bot]](https://avatars.githubusercontent.com/in/249762?s=60&v=4){kind=small}
app-token-plugins
bot
force-pushed
the
fetch-versions
branch
from
f63a2f5
to
c957910
Compare
pkwarren
approved these changes
Oct 22, 2023
app-token-plugins
bot
force-pushed
the
fetch-versions
branch
from
b820e40
to
133efc4
Compare
pkwarren
changed the title
mfridman
reviewed
Oct 23, 2023
| @@ -15,17 +15,17 @@ func TestGatherSourceFilenames(t *testing.T) { | |||
| // Walk entire directory with a depth of 1 | |||
| filenames, err := gatherSourceFilenames("testdata/success") | |||
| require.NoError(t, err) | |||
| assert.Equal(t, 2, len(filenames)) | |||
There was a problem hiding this comment.
That's peculiar, why asserting equal on len doesn't work?
There was a problem hiding this comment.
I don't quite get why cannot use assert.Equal to compare 2 values, but if it made CI pass so be it 🤷
ps. no issues with this PR, mainly trying to understand as I write this assertion often. Imo it reads a bit cleaner with len.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New plugin versions found. Please review.