Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Git-backed
storage.ReadBucket
viastoragegit
#2114Add a Git-backed
storage.ReadBucket
viastoragegit
#2114Changes from 5 commits
adcb9fa
e1be76c
4abbae1
272ef82
880c8bb
c057bd6
4d06edc
9e154b1
29ab534
90c274b
41b3a97
ddc7fcc
73ec4cb
41b5e6b
07fb6c3
45e3331
46a3c26
05f3da7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
Walk
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could go either way, but I felt that
Walk
was overloaded with storage's walk (i.e, it's not walking all paths in a subtree, it's navigating to a particular descendant). MaybeDescendant
is better?