Skip to content

Commit

Permalink
Update to latest connect-go and makego (#2147)
Browse files Browse the repository at this point in the history
  • Loading branch information
pkwarren committed Jun 1, 2023
1 parent 3825738 commit dab6a5b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
4 changes: 4 additions & 0 deletions make/go/base.mk
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@ postgenerate::
.PHONY: licensegenerate
licensegenerate::

.PHONY: format
format::

.PHONY: generate
generate: ## Run all generation steps.
@$(MAKE) preinstallgenerate
Expand All @@ -186,6 +189,7 @@ generate: ## Run all generation steps.
@$(MAKE) postprepostgenerate
@$(MAKE) postgenerate
@$(MAKE) licensegenerate
@$(MAKE) format

.PHONY: checknodiffgenerated
checknodiffgenerated:
Expand Down
4 changes: 2 additions & 2 deletions make/go/dep_protoc_gen_connect_go.mk
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ $(call _assert_var,CACHE_VERSIONS)
$(call _assert_var,CACHE_BIN)

# Settable
# https://github.com/bufbuild/connect-go 20230419 checked 20230420
CONNECT_VERSION ?= v1.7.0
# https://github.com/bufbuild/connect-go 20230531 checked 20230601
CONNECT_VERSION ?= v1.8.0

GO_GET_PKGS := $(GO_GET_PKGS) \
github.com/bufbuild/connect-go@$(CONNECT_VERSION)
Expand Down
6 changes: 5 additions & 1 deletion make/go/go.mk
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ ci:
@$(MAKE) lint
@$(MAKE) test

.PHONY: postupgradegodeps
postupgradegodeps::

.PHONY: upgradegodeps
upgradegodeps:
rm -f go.mod go.sum
Expand All @@ -68,6 +71,7 @@ ifneq ($(GO_GET_PKGS),)
endif
go get -u -t $(GO_ALL_REPO_PKGS) $(GO_GET_PKGS)
go mod tidy -v
@$(MAKE) postupgradegodeps

preupgrade:: upgradegodeps

Expand All @@ -83,7 +87,7 @@ gofmtmodtidy:
@gofmt -s -w $(shell find . -name '*.go')
go mod tidy -v

postgenerate:: gofmtmodtidy
format:: gofmtmodtidy

.PHONY: checknonolint
checknonolint:
Expand Down

0 comments on commit dab6a5b

Please sign in to comment.