mempool/estimatefee: Fix negative index bug #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a negative index bug that makes the node crash on chain reorganizations. The bug is detailed in github.com/btcsuite/issues/1660. A better design than just skipping the transaction would make the fee estimator more accurate and that should implemented at a later date.
Pull Request Test Coverage Report for Build 1874648433
💛 - Coveralls |
Roasbeef
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
LGTM 🍭
Thanks for implementing the suggested fix!
Agree we want another way to do this eventually, but slightly off fee estimations are better than sporadic crashes...
Also would like to follow this up with a repro using the integration test package, but this bug has been lingering too long imo (and we'd likely want to add more fee estimation tests along the way).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a negative index bug that makes the node crash on chain
reorganizations. The bug is detailed in
github.com//issues/1660.
A better design than just skipping the transaction would make
the fee estimator more accurate and that should implemented
at a later date.
Fixes #1660