Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buffer package for use in browser #52

Closed
wants to merge 1 commit into from

Conversation

rvagg
Copy link
Contributor

@rvagg rvagg commented May 7, 2020

Ref #50

This is only used in the browser, Node.js will default to core buffer, so the main cost of this is the dependency weight, but it adds nice future proofing for the browser and Webpack.

@calvinmetcalf
Copy link
Contributor

I'm leaning more towards #53 since we have other cyrpto-browserify prackages that this one depends on that use safe-buffer so using it would add anything to the dependencies and until we can switch all of the crypto-browserify stuff to use the correct thing

@rvagg rvagg closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants