fix srcDir + filtering #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR broccolijs#120 broke the case when you have both `srcDir` and some filtering options like `exclude`. The included test demonstrates the bug. It crashes during `processFile` because the `sourcePath` doesn't exist. This PR fixes the bug by restoring the correct relative paths as inputs to `walkSync`.
ef4
added a commit
to ef4/broccoli-funnel
that referenced
this pull request
Mar 30, 2021
- I need the newer walk sync because it handles symlink cycles - there's a newer broccoli-funnel that already updated, but that one is full of bugs (broccolijs#135 broccolijs#136) and I don't have time right now to unfuck it.
|
I have a similar issue from using I tested your changes and they resolve the problem. @rwjblue Can you review please? |
rwjblue
approved these changes
Apr 13, 2021
|
Wow, fast! Appreciated. |
|
There are other regressions that remain unfixed that stem from the same changes that introduced this bug, see #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #120 broke the case when you have both
srcDirand some filtering options likeexclude. The included test demonstrates the bug. It crashes duringprocessFilebecause thesourcePathdoesn't exist.This PR fixes the bug by restoring the correct relative paths as inputs to
walkSync.