WX-1385 Remove SAS tokens from TES input log printouts #7358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aednichols
changed the title
| import akka.http.scaladsl.model.Uri | ||
|
|
||
| // Remove query that may contain SAS token | ||
| val cleanUrl = url map { Uri(_).copy(rawQueryString = None).toString() } |
There was a problem hiding this comment.
What do you think about only stripping out query params when we can tell the URL contains a SAS token?
Also, can we replace with ?REDACTED or similar so we can tell something was removed? I can imagine users or our future selves not realizing this is happening and thinking Cromwell is incorrectly stripping the query params before passing the URL to TES.
There was a problem hiding this comment.
I was able to enhance and adopt an existing library function for this!
|
scalafmt |
jgainerdewar
approved these changes
Jan 18, 2024
This reverts commit 06e5932.
THWiseman
approved these changes
Jan 18, 2024
|
DBMS issues seem to be a systemic issue with a vendor fix in progress here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.