Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SASL to bubble up errors, enable SASL tests in CI, and add informative empty SASL password message #2901

Conversation

sehrope
Copy link
Contributor

@sehrope sehrope commented Jan 23, 2023

Couple of SASL related commits here:

  1. Enables SASL testing in GitHub actions CI.
  2. Adds a basic unit test for SASL password being a string.
  3. Catches SASL handling errors and bubbles them up as error events.
  4. Adds an explicit check to the SASL handling for an empty password so the user gets an informative email.

Number 3 should actually close out #2757. Interestingly this was brought up in 2019 when the SASL code was first added: #1927. This should close that out too.

@brianc
Copy link
Owner

brianc commented Jan 23, 2023

aww thank you, this is an awesome change! 💃 Will get this merged & pushed out ASAP!

@brianc brianc merged commit bb8745b into brianc:master Jan 23, 2023
@verycosy
Copy link

verycosy commented Feb 3, 2023

AWESOME! Thank you for your commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants