Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use crypto.pbkdf2Sync in sasl auth #2815

Merged
merged 1 commit into from
Sep 27, 2022
Merged

use crypto.pbkdf2Sync in sasl auth #2815

merged 1 commit into from
Sep 27, 2022

Conversation

matej21
Copy link
Contributor

@matej21 matej21 commented Sep 16, 2022

fixes #2814

Copy link
Owner

@brianc brianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thanks for diving in here! Really appreciate the community attention on the parts of the library my venture doesn't use on a day to day basis. I need to make a note to myself to eventually convert this function to async as doing anything with *Sync in the name is probably not as good long term as using the async version....though connections to postgres are already rather slow (due to the protocol and handshake itself) and not extremely common (and the previous code was blocking) so I'm not immediately highly concerned.

@brianc brianc merged commit 9dfb3dc into brianc:master Sep 27, 2022
@matej21
Copy link
Contributor Author

matej21 commented Jan 26, 2023

@brianc hi, when do you plan to release a new version of the pg package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache password hash in SASL auth
3 participants