Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests by other authentication and CI workflow for running tests #76

Conversation

t-ham752
Copy link
Contributor

@t-ham752 t-ham752 commented Feb 3, 2024

Thank you for creating such a wonderful library.
I also wanted to contribute something, so I worked on the following issues:

After working on /issues/40, I found issue /issues/44 and understood that you wanted to remove the bash script.

However, it seemed quite challenging to include the removal of the bash script, so I focused on the following:

  • Adding test cases other than password authentication
  • Adding CI with GitHub Actions

I would be happy if I could contribute. Please review it when you have time.

Sorry, something went wrong.

@t-ham752 t-ham752 marked this pull request as ready for review February 3, 2024 15:59
@bramvdbogaerde bramvdbogaerde merged commit d9bd8d0 into bramvdbogaerde:master Feb 4, 2024
@bramvdbogaerde
Copy link
Owner

bramvdbogaerde commented Feb 4, 2024

Merged! Thanks for your contribution! I noticed that the authentication methods other than password do not seem to work on Github Actions so I added an additional check to the script to disable them when the tests are executed on Github Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants