Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link for configuring Emacs #102

Closed
wants to merge 1 commit into from
Closed

Conversation

qrilka
Copy link

@qrilka qrilka commented Feb 2, 2024

No description provided.

@qrilka
Copy link
Author

qrilka commented Feb 9, 2024

Hi @bram209 is there anything wrong with Github actions on this repo?

@bram209
Copy link
Owner

bram209 commented Feb 16, 2024

I am not sure why, but they are not running for first time contributors (even after approving a PR...).

That aside, thanks for your PR.

The documentation that you wrote for Emacs sets the LSP server setting globally, however the note about VSCode and Neovim are describing how to do project-local LSP configuration. If you set it globally, it will call leptosfmt even for projects that don't use leptos at all. Do you know if this is easy to manage in emacs as well? If so, could you update the documentation?

@qrilka
Copy link
Author

qrilka commented Feb 16, 2024

@bram209 I saw this but I didn't find a way to do that. Ideally that could be solved on rust-analyzer side but we don't have it yet - rust-lang/rust-analyzer#13529
Emacs has dir locals to provide per project settings but those get applied after rust-mode starts rust-analyzer :(
I guess my Emacs-fu isn't strong enough here :-\

@bram209
Copy link
Owner

bram209 commented Feb 23, 2024

Ah okay. I think at this point (having docs for 3+ editors) it makes sense to restructure the readme a bit so that each editor has its own heading.

For example:

# Usage with Rust Analyzer 
...

## VSCode
...

## NeoVim
...

## Emacs
...

## Helix
...

I will restructuring the readme a bit and piggybacking on the Emacs instructions that you provided in this PR. Thanks again for taking the time to contribute : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants