Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py for more up-to-date/robust customisation of the build command #1015

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

abravalheri
Copy link
Contributor

Closes #1014.

This PR proposes 2 changes:

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.30%. Comparing base (f200dac) to head (f803ce7).
Report is 2 commits behind head on main.

❗ Current head f803ce7 differs from pull request most recent head bf12c6a. Consider uploading reports for the commit bf12c6a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   76.42%   76.30%   -0.13%     
==========================================
  Files          61       61              
  Lines        8306     8306              
==========================================
- Hits         6348     6338      -10     
- Misses       1958     1968      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abravalheri
Copy link
Contributor Author

ModuleNotFoundError: No module named 'setuptools.command.build'

Maybe this can be fixed by running python -m build instead of python setup.py build (as that would enforce the build requirement already specified in pyproject.toml).

@sebastinas sebastinas merged commit a9b1324 into bpython:main Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customising build.sub_commands directly from distutils has been deprecated and is about to be removed
2 participants