-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: edit button does not flash when adding new column #890
Conversation
Tests are failing, likely due to your changes. Could you have a look? |
Also, as a good practice, could you add a screen capture to show the improved interaction? |
As a |
The edit button is not displayed anymore: Screen.Recording.2024-07-30.at.16.00.46.mov |
Compare: Screen.Recording.2024-07-30.at.16.01.55.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the CSS before merging this.
packages/dmn-js-decision-table/assets/css/dmn-js-decision-table-controls.css
Outdated
Show resolved
Hide resolved
When merging this, please squash the changes. |
Proposed Changes
Fix for flashing edit button when adding a new column.
Related camunda/camunda-modeler#4388
Screen.Recording.2024-07-24.at.10.10.30.mov
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}