fix: edit button does not flash when adding new column #890
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing, likely due to your changes. Could you have a look? |
|
Also, as a good practice, could you add a screen capture to show the improved interaction? |
|
As a |
|
The edit button is not displayed anymore: Screen.Recording.2024-07-30.at.16.00.46.mov |
|
Compare: Screen.Recording.2024-07-30.at.16.01.55.mov |
barmac
requested changes
Jul 30, 2024
bpmn-io-tasks
bot
added
in progress
bpmn-io-tasks
bot
added
needs review
barmac
reviewed
Jul 31, 2024
packages/dmn-js-decision-table/assets/css/dmn-js-decision-table-controls.css
Outdated
Show resolved
Hide resolved
barmac
approved these changes
Aug 1, 2024
|
When merging this, please squash the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix for flashing edit button when adding a new column.
Related camunda/camunda-modeler#4388
Screen.Recording.2024-07-24.at.10.10.30.mov
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}