Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit button does not flash when adding new column #890

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

jarekdanielak
Copy link
Contributor

@jarekdanielak jarekdanielak commented Jul 24, 2024

Proposed Changes

Fix for flashing edit button when adding a new column.

Related camunda/camunda-modeler#4388

Screen.Recording.2024-07-24.at.10.10.30.mov

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
@jarekdanielak jarekdanielak self-assigned this Jul 24, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 24, 2024
@nikku
Copy link
Member

nikku commented Jul 24, 2024

Tests are failing, likely due to your changes. Could you have a look?

@nikku
Copy link
Member

nikku commented Jul 24, 2024

Also, as a good practice, could you add a screen capture to show the improved interaction?

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
@jarekdanielak jarekdanielak requested a review from barmac July 29, 2024 07:03
@barmac
Copy link
Member

barmac commented Jul 30, 2024

As a fix, this could be targetted at main instead of develop.

@barmac
Copy link
Member

barmac commented Jul 30, 2024

The edit button is not displayed anymore:

Screen.Recording.2024-07-30.at.16.00.46.mov

@barmac
Copy link
Member

barmac commented Jul 30, 2024

Compare:

Screen.Recording.2024-07-30.at.16.01.55.mov

Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the CSS before merging this.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jul 30, 2024

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
@jarekdanielak jarekdanielak changed the base branch from develop to main July 31, 2024 10:01
@jarekdanielak jarekdanielak requested a review from barmac July 31, 2024 10:01
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 31, 2024

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
@jarekdanielak jarekdanielak requested a review from barmac August 1, 2024 10:31
@barmac
Copy link
Member

barmac commented Aug 1, 2024

When merging this, please squash the changes.

@jarekdanielak jarekdanielak merged commit 35e322d into main Aug 2, 2024
8 checks passed
@jarekdanielak jarekdanielak deleted the fix-flashing-edit-button branch August 2, 2024 10:41
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants