Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drd): add Modeling#updateModdleProperties #886

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jul 11, 2024

Proposed Changes

Adds Modeling#updateModdleProperties mirroring bpmn-js.

This is needed in the context of https://github.com/camunda/product-hub/issues/435 as users need to be able add a version tag to a decision through the properties panel. Since the version tag is an extension element we need updateModdleProperties.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 11, 2024
@philippfromme philippfromme changed the title feat(drd): add Modeling#updateModdleProperties feat(drd): add Modeling#updateModdleProperties Jul 11, 2024

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
@philippfromme philippfromme merged commit 72ed313 into develop Jul 11, 2024
6 checks passed
@philippfromme philippfromme deleted the update-moddle-properties branch July 11, 2024 10:00
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 11, 2024
throw new Error('<moddleElement> required');
}

// TODO(nikku): we need to ensure that ID properties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe you kept Nico's name on this :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants