feat(drd): add Modeling#updateModdleProperties
#886
Merged
+152
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
changed the title
Modeling#updateModdleProperties
barmac
reviewed
Jul 15, 2024
| throw new Error('<moddleElement> required'); | ||
| } | ||
|
|
||
| // TODO(nikku): we need to ensure that ID properties |
There was a problem hiding this comment.
I can't believe you kept Nico's name on this :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds
Modeling#updateModdlePropertiesmirroring bpmn-js.This is needed in the context of https://github.com/camunda/product-hub/issues/435 as users need to be able add a version tag to a decision through the properties panel. Since the version tag is an extension element we need
updateModdleProperties.Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}