Fix issues found with axe #843
Merged
+431
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will push more changes to this PR so that we can merge it more easily. Otherwise I'd have to open PRs based on this branch. |
barmac
force-pushed
the
fix-a11y-issues
branch
3 times, most recently
from
f7e2702 to
fac066c
Compare
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
|
The way to verify the fixes that I suggest is via axe dev tools extension for chrome. |
marstamm
reviewed
Apr 5, 2024
...js-decision-table/src/features/decision-rules/components/DecisionRulesCellEditorComponent.js
Show resolved
Hide resolved
marstamm
reviewed
Apr 5, 2024
marstamm
reviewed
Apr 5, 2024
packages/dmn-js-drd/test/spec/features/drill-down/DrillDownSpec.js
Outdated
Show resolved
Hide resolved
marstamm
reviewed
Apr 5, 2024
packages/dmn-js-shared/test/spec/components/EditableComponentSpec.js
Outdated
Show resolved
Hide resolved
|
I found 1 more issue with the axe dev tool. The Expression language dropdown does not have a label. I am not sure if this is relevant at all, as we do not have this field in C8. Otherwise, looks very clean! Great work 👏 |
Co-authored-by: Martin Stamm <martin.stamm@camunda.com>
Done via af13b8d |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/camunda/product-hub/issues/2189
Closes #821