Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found with axe #843

Merged
merged 16 commits into from
Apr 5, 2024
Merged

Fix issues found with axe #843

merged 16 commits into from
Apr 5, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Apr 3, 2024

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 3, 2024
@barmac barmac changed the base branch from develop to main April 3, 2024 12:23
@barmac
Copy link
Member Author

barmac commented Apr 4, 2024

I will push more changes to this PR so that we can merge it more easily. Otherwise I'd have to open PRs based on this branch.

@barmac barmac changed the title fix: add accessible title to drilldown buttons Fix a11y issues Apr 4, 2024
@barmac barmac force-pushed the fix-a11y-issues branch from ff07f4a to d95965c Compare April 4, 2024 12:27
@barmac barmac changed the title Fix a11y issues Fix issues found with axe Apr 4, 2024
@barmac barmac force-pushed the fix-a11y-issues branch 3 times, most recently from f7e2702 to fac066c Compare April 5, 2024 08:50
@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team April 5, 2024 08:50
@barmac barmac force-pushed the fix-a11y-issues branch from fac066c to 49a586d Compare April 5, 2024 08:56
@barmac
Copy link
Member Author

barmac commented Apr 5, 2024

The way to verify the fixes that I suggest is via axe dev tools extension for chrome.

@barmac barmac force-pushed the fix-a11y-issues branch from 49a586d to 5b7e356 Compare April 5, 2024 09:33
barmac added 9 commits April 5, 2024 11:38

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
barmac added 5 commits April 5, 2024 11:38

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
Closes #821
@barmac barmac force-pushed the fix-a11y-issues branch from 765ed48 to 38bd71f Compare April 5, 2024 09:38
@marstamm
Copy link
Contributor

marstamm commented Apr 5, 2024

I found 1 more issue with the axe dev tool. The Expression language dropdown does not have a label. I am not sure if this is relevant at all, as we do not have this field in C8.
image

Otherwise, looks very clean! Great work 👏

Co-authored-by: Martin Stamm <martin.stamm@camunda.com>
@barmac barmac force-pushed the fix-a11y-issues branch from 3c71500 to 9ea6bec Compare April 5, 2024 09:53
Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@barmac
Copy link
Member Author

barmac commented Apr 5, 2024

fix: ensure accessible names for expression language select

Done via af13b8d

@barmac barmac merged commit 23a36e4 into main Apr 5, 2024
8 checks passed
@barmac barmac deleted the fix-a11y-issues branch April 5, 2024 09:58
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants