Remove strict kwarg that was deprecated in Python 3.4 #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3036 +/- ##
===========================================
+ Coverage 93.43% 93.46% +0.02%
===========================================
Files 66 66
Lines 13963 13963
===========================================
+ Hits 13047 13050 +3
+ Misses 916 913 -3
☔ View full report in Codecov by Sentry. |
dlm6693
approved these changes
Oct 10, 2023
|
Hi there, any idea when this would be released to PyPI? |
aws-sdk-python-automation
added a commit
that referenced
this pull request
Oct 12, 2023
* release-1.31.63: Bumping version to 1.31.63 Update to latest partitions and endpoints Update to latest models Remove deprecated `strict` poolmanager kwarg (#3036) add back line Sanitize __type metadata out of response parsing for tagged unions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will stop passing the no-longer required
strictargument to the urllib3 ConnectionPool class. This argument was originally needed inPython<3.5(specifically Python 2) to specify support for older HTTP status lines before http/1.0. The functionality went away in HTTPConnection in Python 3.4 (ref).Starting in urllib3 2.1, this parameter will be removed from the APIs we're using. Given it has no effect on version of Python we support, this should be a no-op for users on all versions of urllib3 we support. You can find a similar PR where we've done this in Requests which has been in place for ~6 months without issue.