Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running tests in environment with NO_COLOR=1 #130

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Nov 24, 2023

Fix running the test suite when pytest is run with NO_COLOR=1 set in the environment. An fixture is autoused to ensure that the variables are removed for the scope of the test, while they are respected e.g. by pytest itself.

@mgorny
Copy link
Contributor Author

mgorny commented Nov 24, 2023

The failures don't seem related to my changes.

Fix running the test suite when pytest is run with NO_COLOR=1 set
in the environment.  An fixture is autoused to ensure that the variables
are removed for the scope of the test, while they are respected
e.g. by pytest itself.
@borntyping borntyping merged commit 6a14458 into borntyping:main Dec 2, 2023
3 of 12 checks passed
@mgorny mgorny deleted the nocolor branch December 2, 2023 16:39
@mgorny
Copy link
Contributor Author

mgorny commented Dec 2, 2023

Thank you!

@borntyping
Copy link
Owner

Thanks for your contribution! Released as part of 6.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants