Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TryFromJs implementations for BTreeMap and HashMap #3844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hansl
Copy link
Contributor

@hansl hansl commented May 9, 2024

No description provided.

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 50.78%. Comparing base (6ddc2b4) to head (ff790f6).
Report is 173 commits behind head on main.

Files Patch % Lines
...e/src/value/conversions/try_from_js/collections.rs 69.23% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3844      +/-   ##
==========================================
+ Coverage   47.24%   50.78%   +3.54%     
==========================================
  Files         476      468       -8     
  Lines       46892    45296    -1596     
==========================================
+ Hits        22154    23004     +850     
+ Misses      24738    22292    -2446     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team May 23, 2024 20:05
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jedel1043 jedel1043 requested a review from a team June 1, 2024 17:47
@jedel1043 jedel1043 added enhancement New feature or request API labels Jun 1, 2024
@jedel1043 jedel1043 added this to the v0.18.1 milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants