Fix regression in ESM plugin loading #658
Merged
+16
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
To prevent the reintroduction of #615,
I refined the condition in
package.json
to return thedefault
export only if it is the only available export.Otherwise, the module will be returned as-is, which should resolve #656.
Note
Since this package supports relatively recent versions of Node:
eslint-doc-generator/package.json
Lines 95 to 97 in cc4d7d6
the entire function could potentially be refactored in the future to primarily use an dynamic
import
instead ofrequire
.For reference: Node's import support status.
Let me know if it's something you're interested in exploring!