Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .prettierrc.json instead of eslint prettier rule to configure format options #654

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

marcalexiei
Copy link
Contributor

During #648 I have some clash between Prettier and ESLint:
I'm using an editor with support for both tools, however they have a different behaviour when dealing with quotes:

To resolve this inconsistency, I added the singleQuote option to .prettierrc.json and removed it from eslint.config.js.
There should be no further issues since the ESLint plugin now reads options directly from Prettier's configuration:
https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#options

Verified

This commit was signed with the committer’s verified signature.
yorickvP Yorick
…nfigure format
@marcalexiei marcalexiei marked this pull request as ready for review March 11, 2025 07:14
@ddzz ddzz requested a review from bmish March 11, 2025 11:38
@bmish bmish added the internal label Mar 11, 2025
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit cc4d7d6 into bmish:main Mar 11, 2025
8 checks passed
@marcalexiei marcalexiei deleted the uniform-prettier-config branch March 11, 2025 13:23
@bmish bmish changed the title chore: use .prettierrc.json instead of eslint prettier rule to configure format options Use .prettierrc.json instead of eslint prettier rule to configure format options Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants