Throw better exception when failing to load plugin #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
May 7, 2023
| @@ -68,7 +68,7 @@ describe('generate (cjs)', function () { | |||
| 'cjs-main-file-does-not-exist' | |||
| ); | |||
| await expect(generate(FIXTURE_PATH)).rejects.toThrow( | |||
| 'Unable to determine plugin entry point.' | |||
There was a problem hiding this comment.
I tried to construct a package.json test case to throw the existing default error... and couldn't figure it out.
There was a problem hiding this comment.
I'll try to take a look at this so we can test the old exception still.
|
@bmish sorry for dropping the ball on this one - totally slipped off my task list. Looks like |
|
@JoshuaKGoldberg no problem and sorry for the delayed review. I will see if I can add a test and get CI cleaned up (#288) in the near future so we can merge this. |
bmish
changed the title
bmish
changed the title
bmish
approved these changes
Nov 13, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Woohoo! I'm just happy it's in, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #446.
Please forgive me for rushing ahead, I was excited about the bugfix. 馃槃