Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go v1.22 and alpine v3.19 #635

Merged
merged 6 commits into from Apr 9, 2024
Merged

go v1.22 and alpine v3.19 #635

merged 6 commits into from Apr 9, 2024

Conversation

bnewbold
Copy link
Collaborator

@bnewbold bnewbold commented Apr 4, 2024

@ericvolp12 I'm not sure why gocql was in the dependency tree (go mod tidy removed it). maybe earlier experimentation, or an accidental commit?

No big rush on this, but the upgrade is pretty easy and feels like we might as well.

Go v1.22 release notes: https://go.dev/blog/go1.22

The main golang improvements are some smallish perf improvements; resolved the "for loop" gotcha; range over integers (yay!); concat slices (finally!); http server pattern matching.

Alpine v3.19 release notes: https://www.alpinelinux.org/posts/Alpine-3.19.0-released.html

@bnewbold bnewbold marked this pull request as draft April 4, 2024 22:06
@bnewbold
Copy link
Collaborator Author

bnewbold commented Apr 4, 2024

hrm, sqlite failed to build, i'll need to resolve that

@bnewbold
Copy link
Collaborator Author

bnewbold commented Apr 4, 2024

go-sqlite3 fixed the build issue a few months back. I'll try updating our version.

mattn/go-sqlite3#1164

@bnewbold bnewbold marked this pull request as ready for review April 4, 2024 22:21
Copy link
Collaborator

@ericvolp12 ericvolp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bnewbold bnewbold merged commit 79c2f8e into main Apr 9, 2024
7 checks passed
@bnewbold bnewbold deleted the bnewbold/go-v1-22 branch April 9, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants