-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appview: support new post search params, viewer context in search #2409
Conversation
tag: params.tag, | ||
until: params.until, | ||
url: params.url, | ||
viewer: params.hydrateCtx.viewer ?? undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to to clarify (I had forgotten for a sec), the reason we pass this to the backend here is to support from:me
search syntax (aka, "search through my own posts").
@@ -56,6 +56,7 @@ const skeleton = async (inputs: SkeletonFnInput<Context, Params>) => { | |||
typeahead: true, | |||
q: term, | |||
limit: params.limit, | |||
viewer: params.hydrateCtx.viewer ?? undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused, we removed this from the schema but added it here 🤔
Are we just passing this through off-spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah—the param was removed from searchActorsTypeahead
, but it still exists on searchActorsSkeleton
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh nice forgot that the same skeleton function serviced both of those 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup yup looks good 👍
* origin/main: (23 commits) Feed context & sendInteractions impl (#2402) Pass through topics headers (#2447) Version packages (#2446) ✨ Allow muting reporter (#2390) Version packages (#2443) Add `savedFeedsPrefV2` and new methods (#2427) fix(ozone): properly import "lande" ES module (from CJS) (#2441) Appview: remove replies to blocked posts from feeds (#2430) PDS: handle S3 upload timeout more gracefully (#2429) Appview: maintain language info when going out to a suggestions service (#2424) Appview: ensure hydration context tracks viewer did and not full service ref (#2423) ✨ Detect language from record content if lang property is not set (#2301) Version packages (#2422) Add email auth factor tools to API (#2419) Version packages (#2417) Lexicons: email auth factor (#2416) Suggestions skeleton impl (#2403) getSuggestionsSkeleton lexicon (#2399) Version packages (#2401) Appview: support new post search params, viewer context in search (#2409) ...
Three changes here in followup to #2396:
viewer
parameter fromapp.bsky.actor.searchActorsTypeahead
.