Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve circular require warning. #491

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Solve circular require warning. #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cdc840
Solve circular require warning.
martijnbolhuis Feb 26, 2024
7ede779
Update dotenv-rails require
bkeepers Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/dotenv-rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
require "dotenv/rails"
require "dotenv"
1 change: 0 additions & 1 deletion lib/dotenv/rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
return
end

require "dotenv"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This require statement shouldn't be necessary since it is already required as the entrypoint of the gem. I suspect that it is still there from the time that Rails integration was a separate gem. Removing this gets rid of the warning in my app and does not seem to break the specs in the dotenv gem.

require "dotenv/replay_logger"
require "dotenv/log_subscriber"

Expand Down