Prevent exception on Rails startup #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not entirely sure if this is the "right" way to fix this (in fact, I'm pretty sure it's not...) But I noticed on a project that since the 3.0 release of `dotenv-rails`, the application would fail to start due to the `ReplayLogger` responding to `#level` as if it were a command to log a statement, rather than a query to determine the level the `Logger` is configured for. You can see the exception here: https://github.com/zinc-collective/convene/actions/runs/7923719579/job/21633994956?pr=2210
|
We were getting this and we tracked it down to a gem version issue. We had (for various old reasons) @zspencer YMMV but that worked for us. |
|
Thanks for taking time to work on this. I took an alternate approach in #492 and just made |
|
That sounds much wiser than my attempt! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if this is the "right" way to fix this (in fact, I'm pretty sure it's not...)
I'm presuming that setting the
ReplayLogger#levelto log the most things will ensure it doesn't drop messages.I noticed on a project that since the 3.0 release of
dotenv-rails, the application would fail to start due to theReplayLoggerresponding to#levelas if it were a command to log a statement, rather than a query to determine the level theLoggeris configured for.You can see the exception here: https://github.com/zinc-collective/convene/actions/runs/7923719579/job/21633994956?pr=2210
The application in question is a Rails 7.1 app, running Ruby 3.2.