Manually check optional Rails dependency version #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I see the integration was recently moved into dotenv on purpose. |
that-jill
pushed a commit
to powerhome/power-web-development-interview
that referenced
this pull request
Feb 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dotenv-rails](https://togithub.com/bkeepers/dotenv) | `3.0.0` -> `3.0.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bkeepers/dotenv (dotenv-rails)</summary> ### [`v3.0.1`](https://togithub.com/bkeepers/dotenv/blob/HEAD/Changelog.md#301) [Compare Source](https://togithub.com/bkeepers/dotenv/compare/v3.0.0...v3.0.1) **What's Changed** - Disable autorestore if using climate_control or ice_age by [@​bkeepers](https://togithub.com/bkeepers) in [bkeepers/dotenv#483 - Join files to Rails.root at load time by [@​bkeepers](https://togithub.com/bkeepers) in [bkeepers/dotenv#484 - Manually check optional Rails dependency version by [@​bkeepers](https://togithub.com/bkeepers) in [bkeepers/dotenv#481 **Full Changelog**: bkeepers/dotenv@v3.0.0...v3.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/powerhome/power-web-development-interview). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
|
Would it make sense to raise instead? When requiring this file, I expect it to work and warnings may or may not be seen. Rails itself for example raises when requiring files that require dependencies that are missing/not satisfied. https://github.com/rails/rails/blob/9aeb1de2455e2988a90a49f73f87b60a58bcd173/activesupport/lib/active_support/cache/redis_cache_store.rb#L3-L11 |
|
@Earlopain I debated about that. I decided not to because of all the unpredicable ways people use dotenv (like in another gem that still has Rails <6.1 in their build matrix). I would really prefer to raise, but I feel uneasy about it. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a manual check for the Rails version before loading the railtie.
Fixes #480