Optionally ignore missing files from cli #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly useful for wrapper scripts (like a `bin/dev` https://stevenharman.net/bin-dev-for-heroku-local) trying to mimic `dotenv-rails`'s ordered loading of multiple files.
Use parentheses for ternary expressions with complex conditions. NOTE: I didn't change these lines, but I think an update to Standard is catching these lingering lint violations?
|
CI was failing to do some Standard.rb linting in files outside the change scope of change in the PR. I've fixed those lint violations in a new commit on this PR; hopefully that will get CI green. |
…issing_files_from_cli * origin/master: Remove EOL Ruby versions from build matrix (2.5, 2.6, 2.7) Fix lint errors Add Ruby 3.3 to the build matrix
|
@stevenharman thanks for the pull request! Sorry it took so long to review. |
indiebrain
pushed a commit
to powerhome/power-web-development-interview
that referenced
this pull request
Feb 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dotenv-rails](https://togithub.com/bkeepers/dotenv) | `2.8.1` -> `3.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bkeepers/dotenv (dotenv-rails)</summary> ### [`v3.0.0`](https://togithub.com/bkeepers/dotenv/blob/HEAD/Changelog.md#300) [Compare Source](https://togithub.com/bkeepers/dotenv/compare/v2.8.1...v3.0.0) **Breaking Changes** - Ruby >= 3.0 and Rails >= 6.1 are now required. Lock dotenv to `~> 2.0` if you are using an outdated Ruby or Rails version. [bkeepers/dotenv#466, [bkeepers/dotenv#471 - `\n` is no longer expanded into a newline in quoted strings. Use multi-line strings with real line breaks, or set `DOTENV_LINEBREAK_MODE=legacy` to preserve the old behavior. [@​nitsujri](https://togithub.com/nitsujri) [bkeepers/dotenv#423 - `ENV` will be [automatically restored between tests](https://togithub.com/bkeepers/dotenv#autorestore-in-tests) (`ActiveSupport::TestCase` and `Rspec`). [bkeepers/dotenv#472, [bkeepers/dotenv#475 - Fixed precedence when using `Dotenv::Rails.overload`. So now `.env.development.local` will overwrite `.env.local`, which will overwrite `.env.development`, which will overwrite `.env`. [@​eriklovmo](https://togithub.com/eriklovmo) - [bkeepers/dotenv#460 - The instrumentation event `dotenv.load` has been renamed to `load.dotenv` to properly make use of namespaces in [ActiveSupport::Notifications](https://guides.rubyonrails.org/active_support_instrumentation.html) [bkeepers/dotenv#472 **Other improvements** - All changes to ENV will be logged in Rails apps. [bkeepers/dotenv#473 - Fixed an issue where `rake` loaded development files (`.env*development`) for test-related tasks. [bkeepers/dotenv#470 - Add `-i`/`--ignore` option to `dotenv` CLI to optionally ignore missing files. [@​stevenharman](https://togithub.com/stevenharman) [bkeepers/dotenv#463 - You can [customize which files get loaded](https://togithub.com/bkeepers/dotenv#customizing-rails) by setting `Dotenv::Rails.files`. [bkeepers/dotenv#468 **Deprecations** - The `dotenv-rails` gem is now superfluous. It's not technically deprecated yet and will continue to work, but the `dotenv` gem does the same thing. [bkeepers/dotenv#468 - `Dotenv::Railtie` has been deprecated. Use `Dotenv::Rails`. [bkeepers/dotenv#468 - `Dotenv.overload` has been replaced with `overwrite`. `overload` will still work and is not technically deprecated, but documentation refers to `Dotenv.overwrite` now. [bkeepers/dotenv#469 **New Contributors** - [@​stevenharman](https://togithub.com/stevenharman) made their first contribution in [bkeepers/dotenv#463 - [@​eriklovmo](https://togithub.com/eriklovmo) made their first contribution in [bkeepers/dotenv#460 - [@​nitsujri](https://togithub.com/nitsujri) made their first contribution in [bkeepers/dotenv#423 **Full Changelog**: bkeepers/dotenv@v2.8.1...v3.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/powerhome/power-web-development-interview). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly useful for wrapper scripts (like a
bin/dev) trying to mimicdotenv-rails's ordered loading of multiple files.