feat!: Remove jest eslint rules #117
Merged
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braaar
approved these changes
Oct 10, 2022
theneva
reviewed
Oct 10, 2022
README.md
Outdated
| project anymore. Versions below v3 **require** `jest`, which just doesn't make | ||
| sense to us. | ||
|
|
||
| However, there are a few steps needed to get it working anyway: |
There was a problem hiding this comment.
This line reads to me like: "There were already some steps required, so dropping it doesn't really make much of a difference"
What about changing it to something like: "Here are the steps to get it working [again]:", or just "To get it working [again], do the following{.,:}"?
simenandre
force-pushed
the
remove-jest
branch
from
2f629e2 to
a92b092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our current rendition of
@bjerk/eslint-config, we requirejestto be installed.I'm not sure that is the best approach for going forward, as we don't necessarily want to use Jest for every project anymore. A native test runner is coming, and there are also projects where we don't want/need Jest (or testing at all).
I think we have to balance it, though. Is it easy to manually add jest eslint rules? See my guide here: https://github.com/bjerkio/eslint-config/blob/remove-jest/README.md#migrate-from-v2