Skip to content

Commit 0ef4ee1

Browse files
authoredOct 18, 2022
feat!: Remove jest eslint rules (#117)
1 parent 4b4ea78 commit 0ef4ee1

File tree

4 files changed

+26
-18
lines changed

4 files changed

+26
-18
lines changed
 

‎README.md

+24
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,27 @@ To make all this config work, you only need to add this to `package.json`:
3030
}
3131
}
3232
```
33+
34+
## Migrate from v2?
35+
36+
We removed `jest`-related rules in v3, essentially making `jest` an optional
37+
dependency. In our experience, we don't necessarily want to use Jest for every
38+
project anymore. Versions below v3 **require** `jest`, which just doesn't make
39+
sense to us.
40+
41+
Here are the steps to get it working [again]:
42+
43+
Run this in your terminal:
44+
45+
```shell
46+
yarn add -D eslint-plugin-jest
47+
```
48+
49+
```json
50+
{
51+
"eslintConfig": {
52+
"extends": ["@bjerk/eslint-config", "plugin:jest/recommended"],
53+
"plugins": ["jest"]
54+
}
55+
}
56+
```

‎index.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@ module.exports = {
1010
'plugin:@typescript-eslint/recommended',
1111
'plugin:eslint-comments/recommended',
1212
'plugin:promise/recommended',
13-
'plugin:jest/recommended',
1413
'prettier',
1514
],
1615
parser: '@typescript-eslint/parser',
17-
plugins: ['@typescript-eslint', 'jest', 'import', 'unicorn'],
16+
plugins: ['@typescript-eslint', 'import', 'unicorn'],
1817
rules: {
1918
curly: 'error',
2019
'@typescript-eslint/explicit-module-boundary-types': 'warn',

‎package.json

-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"eslint-config-prettier": "^8.5.0",
1515
"eslint-plugin-eslint-comments": "^3.2.0",
1616
"eslint-plugin-import": "^2.26.0",
17-
"eslint-plugin-jest": "^27.0.4",
1817
"eslint-plugin-prettier": "^4.2.1",
1918
"eslint-plugin-promise": "^6.0.1",
2019
"eslint-plugin-unicorn": "^43.0.2",
@@ -27,7 +26,6 @@
2726
"eslint-config-prettier": "^8.5.0",
2827
"eslint-plugin-eslint-comments": "^3.2.0",
2928
"eslint-plugin-import": "^2.26.0",
30-
"eslint-plugin-jest": "^27.0.4",
3129
"eslint-plugin-prettier": "^4.2.1",
3230
"eslint-plugin-promise": "^6.0.1",
3331
"eslint-plugin-unicorn": "^43.0.2",
@@ -40,7 +38,6 @@
4038
"eslint-config-prettier",
4139
"eslint-plugin-eslint-comments",
4240
"eslint-plugin-import",
43-
"eslint-plugin-jest",
4441
"eslint-plugin-prettier",
4542
"eslint-plugin-promise",
4643
"eslint-plugin-unicorn",

‎yarn.lock

+1-13
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@
194194
semver "^7.3.7"
195195
tsutils "^3.21.0"
196196

197-
"@typescript-eslint/utils@5.39.0", "@typescript-eslint/utils@^5.10.0":
197+
"@typescript-eslint/utils@5.39.0":
198198
version "5.39.0"
199199
resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-5.39.0.tgz#b7063cca1dcf08d1d21b0d91db491161ad0be110"
200200
integrity sha512-+DnY5jkpOpgj+EBtYPyHRjXampJfC0yUZZzfzLuUWVZvCuKqSdJVC8UhdWipIw7VKNTfwfAPiOWzYkAwuIhiAg==
@@ -550,13 +550,6 @@ eslint-plugin-import@^2.26.0:
550550
resolve "^1.22.0"
551551
tsconfig-paths "^3.14.1"
552552

553-
eslint-plugin-jest@^27.0.4:
554-
version "27.0.4"
555-
resolved "https://registry.yarnpkg.com/eslint-plugin-jest/-/eslint-plugin-jest-27.0.4.tgz#ab9c7b3f48bfade4762c24c415a5d9bbc0174a61"
556-
integrity sha512-BuvY78pHMpMJ6Cio7sKg6jrqEcnRYPUc4Nlihku4vKx3FjlmMINSX4vcYokZIe+8TKcyr1aI5Kq7vYwgJNdQSA==
557-
dependencies:
558-
"@typescript-eslint/utils" "^5.10.0"
559-
560553
eslint-plugin-prettier@^4.2.1:
561554
version "4.2.1"
562555
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-4.2.1.tgz#651cbb88b1dab98bfd42f017a12fa6b2d993f94b"
@@ -803,11 +796,6 @@ function-bind@^1.1.1:
803796
resolved "https://registry.yarnpkg.com/function-bind/-/function-bind-1.1.1.tgz#a56899d3ea3c9bab874bb9773b7c5ede92f4895d"
804797
integrity sha512-yIovAzMX49sF8Yl58fSCWJ5svSLuaibPxXQJFLmBObTuCr0Mf1KiPopGM9NiFjiYBCbfaa2Fh6breQ6ANVTI0A==
805798

806-
functional-red-black-tree@^1.0.1:
807-
version "1.0.1"
808-
resolved "https://registry.yarnpkg.com/functional-red-black-tree/-/functional-red-black-tree-1.0.1.tgz#1b0ab3bd553b2a0d6399d29c0e3ea0b252078327"
809-
integrity sha1-GwqzvVU7Kg1jmdKcDj6gslIHgyc=
810-
811799
get-intrinsic@^1.0.2, get-intrinsic@^1.1.0, get-intrinsic@^1.1.1:
812800
version "1.1.1"
813801
resolved "https://registry.yarnpkg.com/get-intrinsic/-/get-intrinsic-1.1.1.tgz#15f59f376f855c446963948f0d24cd3637b4abc6"

0 commit comments

Comments
 (0)
Please sign in to comment.