Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scss/at-mixin-pattern rule #279

Merged
merged 1 commit into from Mar 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- "number-no-trailing-zeros": true
- "selector-list-comma-newline-after": "always"
- "string-quotes": "single"
- Removed scss/at-mixin-pattern rule. Resolves [#181](https://github.com/bjankord/stylelint-config-sass-guidelines/issues/181) and [#191](https://github.com/bjankord/stylelint-config-sass-guidelines/issues/191)

## [9.0.1]
### Changed
Expand Down
9 changes: 2 additions & 7 deletions __tests__/unit/name-format.spec.js
Expand Up @@ -21,7 +21,7 @@ $myVar: 10px;
`)

test("Name format scss", t => {
t.plan(5)
t.plan(4)

postcss()
.use(stylelint({ code: invalidScss, config: config,}))
Expand All @@ -30,18 +30,13 @@ test("Name format scss", t => {
.catch(logError)

function checkResult(result) {
t.equal(result.warnings().length, 4, "flags 4 warning")
t.equal(result.warnings().length, 3, "flags 3 warning")
var warningsArray = Object.values(result.warnings()).map(x => x.text);
t.is(
warningsArray.includes('Expected @function name to match specified pattern (scss/at-function-pattern)'),
true,
'correct warning text',
)
t.is(
warningsArray.includes('Expected @mixin name to match specified pattern (scss/at-mixin-pattern)'),
true,
'correct warning text',
)
t.is(
warningsArray.includes('Expected $ variable name to match specified pattern (scss/dollar-variable-pattern)'),
true,
Expand Down
1 change: 0 additions & 1 deletion index.js
Expand Up @@ -44,7 +44,6 @@ module.exports = {
"scss/at-function-pattern": "^[a-z]+([a-z0-9-]+[a-z0-9]+)?$",
"scss/at-import-no-partial-leading-underscore": true,
"scss/at-import-partial-extension-blacklist": ["scss"],
"scss/at-mixin-pattern": "^[a-z]+([a-z0-9-]+[a-z0-9]+)?$",
"scss/at-rule-no-unknown": true,
"scss/dollar-variable-colon-space-after": "always",
"scss/dollar-variable-colon-space-before": "never",
Expand Down