-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/rabbitmq] allow to configure trafficDistribution #32443
[bitnami/rabbitmq] allow to configure trafficDistribution #32443
Conversation
Signed-off-by: Rémi Beaufils <remi.beaufils@claranet.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
159512d
to
74466ad
Compare
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
## @param service.trafficDistribution Traffic Distribution provides another | ||
## way to influence traffic routing within a Kubernetes Service. | ||
## | ||
trafficDistribution: "PreferClose" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @rossifumax
first of all, thanks a lot for your PR.
I have a question about your changes. Why by default "PreferClose"? Maybe it is a good idea to set up the value to empty one and just include the trafficDistribution in case that the users want to set up it to trafficDistribution. What do you think?
Thanks a lot again
Álvaro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @alvneiayu,
In my opinion, the default value should be set to PreferClose
for all services for various reasons (performance, cost, reliability).
However, depending on the use cases, it might be necessary to change this setting when pods on the same node or zone become overloaded.
What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @alvneiayu
Btw, i already had a conversation about this feature and the defaults to apply on the Opensearch helm chart if you want to take a look : #32442 (comment)
Regards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @rossifumax , thanks a lot for your answer. Everything clear then on my side. Again, thanks a lot for your contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello !
Description of the change
Add trafficDistribution feature on svc-headless of RabbitMQ.
This feature is available since k8s v1.31.
Benefits
Take advantage of the new feature trafficDistribution.
cf. https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution
Possible drawbacks
Normally, no drawbacks.
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm