[bitnami/mongodb] Update dns-check init container condition #32394
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates the
dns-check
init container conditional to not include.Values.externalAccess.service.domain
.The value
externalAccess.service.domain
didn't interfere in any way with thedns-check
init container, which led us to two possible scenarios:externalAccess.service.publicNames
is set, the dns-check will ensure that indeed the pod is able to resolve the DNS.externalAccess.service.publicNames
is NOT set, butexternalAccess.service.domain
is, thedns-check
will perform a check on the pod's FQDN, e.g.mongodb-0.svc.mongodb-hl.my-ns.cluster.local
.This second scenario doesn't really make sense, because the headless service is configured with
publishNotReadyAddresses=true
, and performing a DNS check on a headless service is unnecessary.Benefits
Simplifies the logic and fixes an existing issue with the
dns-check
init container, where check would never pass because variableMY_POD_NAMESPACE
was never defined.Possible drawbacks
None known.
Applicable issues
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm