Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mongodb] Update dns-check init container condition #32394

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

migruiz4
Copy link
Member

Description of the change

Updates the dns-check init container conditional to not include .Values.externalAccess.service.domain.

The value externalAccess.service.domain didn't interfere in any way with the dns-check init container, which led us to two possible scenarios:

  • When externalAccess.service.publicNames is set, the dns-check will ensure that indeed the pod is able to resolve the DNS.
  • When externalAccess.service.publicNames is NOT set, but externalAccess.service.domain is, the dns-check will perform a check on the pod's FQDN, e.g. mongodb-0.svc.mongodb-hl.my-ns.cluster.local.

This second scenario doesn't really make sense, because the headless service is configured with publishNotReadyAddresses=true, and performing a DNS check on a headless service is unnecessary.

Benefits

Simplifies the logic and fixes an existing issue with the dns-check init container, where check would never pass because variable MY_POD_NAMESPACE was never defined.

Possible drawbacks

None known.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
hudlow Dan Hudlow
Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com>
@github-actions github-actions bot added mongodb verify Execute verification workflow for these changes bitnami labels Mar 11, 2025
@github-actions github-actions bot requested a review from jotamartos March 11, 2025 10:03
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM but if we remove usage from .Values.externalAccess.service.domain here, it's almost unused in the chart. I think we can change the logic to use .Values.externalAccess.service.publicNames and remove the other parameter.

@migruiz4 migruiz4 merged commit 430e759 into main Mar 12, 2025
13 checks passed
@migruiz4 migruiz4 deleted the mongodb-dns-check-condition branch March 12, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami mongodb solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/mongodb] dnsCheck needs $MY_POD_NAMESPACE to be set
2 participants