Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] allow custom service labels for primary and read #32368

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

ivaanko
Copy link
Contributor

@ivaanko ivaanko commented Mar 7, 2025

Signed-off-by: Ivan Korolev ivaanko@gmail.com

Description of the change

This extends templates for PostgreSQL primary and read services to allow passing custom labels from values.

Benefits

Until now there was no ability to add custom values to the primary and read services. These labels can be used, for example, to control load balancer node pools.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

@github-actions github-actions bot added postgresql triage Triage is needed labels Mar 7, 2025
@github-actions github-actions bot requested a review from carrodher March 7, 2025 16:02
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Mar 7, 2025
@github-actions github-actions bot removed the triage Triage is needed label Mar 7, 2025
@github-actions github-actions bot removed the request for review from carrodher March 7, 2025 17:33
@github-actions github-actions bot requested a review from gongomgra March 7, 2025 17:33
@carrodher
Copy link
Member

Testing is failing due to:

Error: INSTALLATION FAILED: template: cp-charts-repository/templates/read/svc.yaml:13:16: executing "cp-charts-repository/templates/read/svc.yaml" at <.Values.read.service.labels>: nil pointer evaluating interface {}.service

Could you please take a look?

@ivaanko
Copy link
Contributor Author

ivaanko commented Mar 11, 2025

Hi @gongomgra ! I've fixed the tests and also resolved semver conflict with a version that was released during this period, could you proceed with the review, please? Thank you!

@ivaanko ivaanko force-pushed the service_labels branch 3 times, most recently from 9ac4be2 to 6f88436 Compare March 17, 2025 15:38
ivaanko added 3 commits March 20, 2025 08:34

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
Signed-off-by: Ivan Korolev <ivaanko@gmail.com>
fix typo

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
Signed-off-by: Ivan Korolev <ivaanko@gmail.com>
Signed-off-by: Ivan Korolev <ivaanko@gmail.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Copy link
Contributor

@gongomgra gongomgra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@gongomgra gongomgra merged commit 6703679 into bitnami:main Mar 20, 2025
12 checks passed
@ivaanko ivaanko deleted the service_labels branch March 21, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postgresql solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql] allow adding custom labels to primary and read services
4 participants