[bitnami/postgresql] Add secretAnnotation value #31984
Merged
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-cheb
force-pushed
the
psql-add-secret-annotations
branch
2 times, most recently
from
bce4858 to
53448d2
Compare
carrodher
added
verify
al-cheb
force-pushed
the
psql-add-secret-annotations
branch
from
32801a3 to
43c9464
Compare
update PR link Signed-off-by: Alexander Chebotov <a.chebotov@arenadata.io>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Alexander Chebotov <a.chebotov@arenadata.io>
Signed-off-by: Alexander Chebotov <a.chebotov@arenadata.io>
Signed-off-by: Alexander Chebotov <a.chebotov@arenadata.io>
al-cheb
force-pushed
the
psql-add-secret-annotations
branch
from
43c9464 to
1a80441
Compare
Signed-off-by: Alexander Chebotov <a.chebotov@arenadata.io>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Alexander Chebotov <a.chebotov@arenadata.io>
al-cheb
force-pushed
the
psql-add-secret-annotations
branch
from
e45dc5a to
728bbff
Compare
|
@carrodher, @migruiz4, hey, could you please review this PR? |
Signed-off-by: Aleksandr Chebotov <47745270+al-cheb@users.noreply.github.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com> Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
migruiz4
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
These changes should allow annotations to be added to the postgresql secrets only.
My use case is that I want to use vault-webhool to reflect the postgresql secret.
Benefits
Allow to add annotations on secret only.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm