New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterator over all the enabled options #278
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e2ec673
Iterator over all the enabled options
arturoc abc1e0c
Merge branch 'fix_serde_tests' into iterators
arturoc 229f196
iterators: add tests
arturoc c18695a
Merge branch 'main' of https://github.com/bitflags/bitflags into iter…
arturoc 4ba731a
iterators: preserve order of flags
arturoc c5a5c15
iterator: options array doesn't need to be mut
arturoc 46fbbc3
iterators: make options array const
arturoc 00058b1
iterators: remove unnecesary check
arturoc 5f753e1
iterators: no need to iterate over a range anymore
arturoc 6656792
iterator: add cfg to tests
arturoc File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add a cfg'd-out flag to this as well just to make sure we handle those? Something like:
and then use those matching cfgs to check that we iterate over those flags when they're available, but don't when they're not?