Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde tests fail in CI #277

Merged
merged 1 commit into from Apr 20, 2022
Merged

serde tests fail in CI #277

merged 1 commit into from Apr 20, 2022

Conversation

arturoc
Copy link

@arturoc arturoc commented Apr 19, 2022

Cause Serialize and Deserialize derives are used from serde:: instead of serde_derive::

Cause Serialize and Deserialize derives are used from serde:: instead of serde_derive::
@KodrAus
Copy link
Member

KodrAus commented Apr 20, 2022

Hmm, it looks like our tests have bit-rotted a bit here. If you run them locally with TRYBUILD=overwrite it should update those expected build failure output files.

@arturoc
Copy link
Author

arturoc commented Apr 20, 2022

I wasn't sure if I should do that. I'll send a different PR with the fix for the trybuild tests and merge it in these ones

@KodrAus
Copy link
Member

KodrAus commented Apr 20, 2022

I should write something up in the contributing docs for it 🙂 If you leave it to me I'll take care of it. I think we might do something special so the output is only checked in beta builds.

@arturoc
Copy link
Author

arturoc commented Apr 20, 2022

Yes that's what I was thinking. It's only in beta so not sure that running TRYBBUILD even using a beta version would overwrite the right files

@arturoc arturoc mentioned this pull request Apr 20, 2022
@KodrAus
Copy link
Member

KodrAus commented Apr 20, 2022

Thanks @arturoc. I'll merge this one in and rebase my updates to the test output on top.

@KodrAus KodrAus merged commit 24a0662 into bitflags:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants