Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_bits_(truncate) fail with composite flags #276

Merged
merged 8 commits into from Apr 28, 2022

Commits on Apr 19, 2022

  1. from_bits_(truncate) fail with composite flags

    When a bitflags type contains composite flags like:
    
    ```rs
    bitflags! {
        struct Flags: u8 {
                const A = 0b00000001;
                const BC = 0b00000110;
        }
    }
    ```
    
    from_bits and from_bits_truncate would not work as expected allowing flags that are not declared.
    
    Fixes bitflags#275
    arturoc committed Apr 19, 2022
    Copy the full SHA
    8b10fe1 View commit details
    Browse the repository at this point in the history
  2. fix previous commit

    extra brace commited accidentally due to partial staging
    arturoc committed Apr 19, 2022
    Copy the full SHA
    8a5eb88 View commit details
    Browse the repository at this point in the history
  3. serde::Serialize -> serde_derive::Serialize

    serde:: doesn't work on tests on CI
    arturoc committed Apr 19, 2022
    1
    Copy the full SHA
    44c7063 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Copy the full SHA
    3616bd5 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    00fddb8 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. fix from_bits

    was still wrong for some edge cases
    arturoc committed Apr 26, 2022
    Copy the full SHA
    7253391 View commit details
    Browse the repository at this point in the history
  2. fix should fail output

    changed on last commit
    arturoc committed Apr 26, 2022
    Copy the full SHA
    ea776b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Copy the full SHA
    0ef1316 View commit details
    Browse the repository at this point in the history