Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic tree transport #103

Merged
merged 18 commits into from
Jan 30, 2024
Merged

Dynamic tree transport #103

merged 18 commits into from
Jan 30, 2024

Conversation

Flova
Copy link
Member

@Flova Flova commented Jan 29, 2024

Summary

  • No hard-coded DSD paths in the VIZ anymore
  • No second DSD running in the viz node
  • Tree json serialization
  • Provide the tree on a latched topic
  • Hot reload if DSD tree changes
  • The viz subscribes to that topic and discovers DSDs that are currently active automatically using it
  • Non hardcoded ROS params are now displayed properly
  • Option to show the full tree (kinda slow for large trees, need to optimize that)
  • Fix highlight button
  • Disable fit to view if the user scrolls once
  • Better caching (it actually does something now)
  • Typing annotations
  • Backward compatible viz for ROS Bags that include the latched tree topic in the future if the local files change
  • Some color changes

Closes #102
Closes #56
Closes #69

@Flova
Copy link
Member Author

Flova commented Jan 29, 2024

We might need to check that the UDP bridge and ros bag recordings work with latched topics and also record or transmit the correct topics.

@Flova Flova mentioned this pull request Jan 29, 2024
Flova and others added 6 commits January 29, 2024 22:18
…alization/dsd_follower.py

Co-authored-by: Jan Gutsche <34797331+jaagut@users.noreply.github.com>
…alization/dsd_visualization_plugin.py

Co-authored-by: Jan Gutsche <34797331+jaagut@users.noreply.github.com>
…alization/dsd_visualization_plugin.py

Co-authored-by: Jan Gutsche <34797331+jaagut@users.noreply.github.com>
…alization/dsd_follower.py

Co-authored-by: Jan Gutsche <34797331+jaagut@users.noreply.github.com>
@Flova Flova requested a review from jaagut January 29, 2024 21:48
@jaagut jaagut merged commit 3a64080 into master Jan 30, 2024
1 check passed
@jaagut jaagut deleted the dynamic_tree_transport branch January 30, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants